Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add gaze.transforms.smooth() #555

Merged
merged 26 commits into from
Sep 29, 2023
Merged

feat: Add gaze.transforms.smooth() #555

merged 26 commits into from
Sep 29, 2023

Conversation

jakobchwastek
Copy link
Member

@jakobchwastek jakobchwastek commented Sep 14, 2023 •
edited
Loading

Description

Fixes issue #301

Implemented changes

Implementation of transforms.smooth function for smoothing data. The following methods have been
implemented

  • Moving Average
  • Exponential Moving Average
  • Savitzky Golay

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested smoothing methods by applying them to a simple 2D array with values [[0., 0.], [1., 1.], [0., 0.]].

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jakobchwastek jakobchwastek linked an issue Sep 14, 2023 that may be closed by this pull request
Add transforms.smooth() #301
Closed
1 task
@dkrako dkrako changed the title Feature/add transforms smooth feat: Add gaze.transforms.smooth() Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c8ef04d) 100.00% compared to head (67bbbde) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #555   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           52        52           
  Lines         2258      2289   +31     
  Branches       559       570   +11     
=========================================
+ Hits          2258      2289   +31
Files Coverage Δ
src/pymovements/gaze/gaze_dataframe.py 100.00% <100.00%> (ø)
src/pymovements/gaze/transforms.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dkrako
dkrako requested changes Sep 14, 2023
View reviewed changes
src/pymovements/gaze/transforms.py Outdated Show resolved Hide resolved
jakobchwastek and others added 10 commits September 14, 2023 16:59
@jakobchwastek
Fix mypy typing error
5a7f63e
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b345aae 
for more information, see https://pre-commit.ci
@jakobchwastek
* Fix No blank lines allowed after function docstring
8c6eceb 
* Fix First line should end with a period (not 'g')
@jakobchwastek
Merge remote-tracking branch 'origin/feature/add-transforms-smooth' i…
a92e61b 
…nto feature/add-transforms-smooth
@jakobchwastek
* minor fix pad_width type
f74a75f 
* use rounded up half of window_length as padding length
* add tests for all smoothing methods
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
288f087 
for more information, see https://pre-commit.ci
@jakobchwastek
* add elif; try fix coverage exponential_moving_average
8457c30
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
bf0be39 
for more information, see https://pre-commit.ci
@jakobchwastek
* Fix coverage
3613e69
@jakobchwastek
* Remove unnecessary "else" after "return"
590be44
@jakobchwastek jakobchwastek marked this pull request as ready for review September 22, 2023 06:47
@jakobchwastek
Copy link
Member Author

Adding smooth as transformation method in GazeDataFrame is missing!

@jakobchwastek jakobchwastek marked this pull request as draft September 22, 2023 07:10
@jakobchwastek jakobchwastek marked this pull request as ready for review September 22, 2023 08:59
dkrako
dkrako approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@dkrako dkrako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this great work!

@dkrako dkrako merged commit dc3a32d into main Sep 29, 2023
17 checks passed
@dkrako dkrako deleted the feature/add-transforms-smooth branch September 29, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkrako dkrako dkrako approved these changes

@SiQube SiQube Awaiting requested review from SiQube SiQube is a code owner

@prassepaul prassepaul Awaiting requested review from prassepaul prassepaul is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add transforms.smooth()
3 participants
@jakobchwastek @dkrako @SiQube